Commit Graph

43 Commits

Author SHA1 Message Date
Andrés Eduardo García Márquez 4b9fe1c33b feat(domain): add student account activation fields
Add activation-related properties to Student entity:
- IsActive: boolean flag for account activation status
- ActivationCode: 6-digit code for email verification
- ActivationCodeExpiry: expiration timestamp for the code

Add repository method GetByActivationCodeAsync for code lookup.

These changes support the new student self-registration flow where
accounts require email verification before accessing the system.
2026-01-09 07:41:42 -05:00
Andrés Eduardo García Márquez 72a7fed64f ci: trigger pipeline test with .NET SDK runner 2026-01-09 07:38:36 -05:00
Andrés Eduardo García Márquez be87cd3801 ci: optimize pipeline with .NET image, smoke tests, and auto-rollback
Changes:
- Runner now uses mcr.microsoft.com/dotnet/sdk:9.0 image
- Simplified test job (build + unit tests only)
- Deploy uses git pull instead of rsync for faster updates
- Added smoke tests in production:
  - Health check API
  - Health check Frontend
  - GraphQL endpoint validation
  - Database connectivity check
  - Subjects query test
- Auto-rollback if smoke tests fail

Flow: test -> deploy -> smoke-tests -> (rollback on failure)
2026-01-09 07:35:58 -05:00
Andrés Eduardo García Márquez d8bfe3bee7 fix(k3s): increase SQL Server memory limits to prevent OOMKilled
- Memory limit: 384Mi → 768Mi
- Memory request: 256Mi → 512Mi
- MSSQL_MEMORY_LIMIT_MB: 340 → 512

Previous limits caused OOMKilled restarts during SQL Server startup.
2026-01-09 07:19:42 -05:00
Andrés Eduardo García Márquez d8a01f904d ci: add tests job before deploy, fix namespace to academia
- Add test job that runs Domain, Application, and Integration tests
- Deploy job now depends on test job (needs: test)
- Fix namespace from student-enrollment to academia
- Update sync path from student-enrollment to academia
- Always apply kustomize before rollout restart
2026-01-09 07:08:21 -05:00
Andrés Eduardo García Márquez 1455f729b2 docs: add explicit Git credentials reference to DEV-GUIDE.md
- Add GIT_USER, GIT_PASS, GIT_REMOTE_URL variables
- Make auto-login mandatory rule
- Reference ~/.secrets/credentials.env for all auth
2026-01-08 16:51:50 -05:00
Andrés Eduardo García Márquez b91b278d01 docs: add credentials section and update namespace to academia
- Document ~/.secrets/credentials.env usage
- Add auto-login examples for Gitea, API, and K3s
- Update namespace from student-enrollment to academia
- Remove DEV-GUIDE.md from .gitignore to track in repo
2026-01-08 16:48:56 -05:00
Andrés Eduardo García Márquez 2568990465 refactor(k3s): rename namespace from student-enrollment to academia 2026-01-08 16:44:22 -05:00
Andrés Eduardo García Márquez 1ad090329b fix(k3s): update image names and deployment docs
- Rename images from academia-* to student-* for consistency
- Update DEPLOYMENT.md with latest deployment procedures
2026-01-08 16:40:57 -05:00
Andrés Eduardo García Márquez c15702746a ci: optimize deployment workflow for k3s
- Single job instead of 3 (no artifact overhead)
- Build directly on k3s node (avoids image transfer)
- Parallel Docker builds with BuildKit
- Auto-create namespace if missing
- Automatic rollback on failure
- Health check via domain
2026-01-08 13:34:38 -05:00
Andrés Eduardo García Márquez 3e66b63ac7 fix(docker): alpine compatibility and k3s deployment fixes
- Add linux-musl-x64 runtime identifier for Alpine builds
- Install ICU libs for SQL Server globalization support
- Fix nginx upstream to use k8s service name (student-api)
- Sync package-lock.json with package.json
2026-01-08 11:53:28 -05:00
Andrés Eduardo García Márquez 4af01f1008 fix(docker): update to .NET 10 SDK for k3s deployment
- Update Dockerfile.api to use dotnet/sdk:10.0-alpine
- Update runtime to aspnet:10.0-alpine
- Add deploy-k3s.sh script for manual deployments
2026-01-08 11:30:24 -05:00
Andrés Eduardo García Márquez 9f25e8bf9d docs: add QA regression report and update recommendations
- Add regression test report with 14 passed tests
- Verify DEF-001 and DEF-002 fixes
- Update recommendations with CI/CD deployment info
2026-01-08 11:23:19 -05:00
Andrés Eduardo García Márquez a98862add8 feat: add CI/CD pipeline, password recovery, and QA improvements
- Add Gitea Actions workflow for automated k3s deployment
- Implement password recovery with recovery codes (no email needed)
- Fix unenroll mutation (missing studentId parameter)
- Fix dashboard handling for expired sessions
- Add optimized Docker builds with caching
- Add k3s all-in-one deployment manifest
- Add QA test report and recommendations
2026-01-08 10:49:32 -05:00
Andrés Eduardo García Márquez 49c74ab868 feat(frontend): implement student self-registration and dashboard
- Make name and email required in registration form
- Add StudentDashboard component with enrolled subjects and program info
- Implement role-based navigation (admin sees management, student sees portal)
- Add adminGuard for restricting student management routes
- Redirect to /dashboard after login/register instead of /students
- Add navigation links: Mi Portal, Mis Materias, Companeros

Fulfills test requirements:
- Students can register online (punto 1)
- Enroll in up to 3 subjects/9 credits (puntos 2-5)
- Cannot have same professor twice (punto 7)
- View classmates by subject - names only (puntos 8-9)
2026-01-08 09:37:19 -05:00
Andrés Eduardo García Márquez 9d8c6f0331 refactor(backend): add validation patterns, query validators, and test builders
- Add centralized ValidationPatterns with XSS protection and name regex
- Add query validators (GetClassmates, GetStudentById, GetStudentsPaged, GetAvailableSubjects)
- Add ClassmateInfo read model for optimized query projections
- Add test builders (Student, Subject, Professor, Enrollment) for cleaner tests
- Improve repository interfaces with XML documentation
- Refactor EnrollmentRepository for better performance
- Update EnrollmentDomainService with additional validation helpers
2026-01-08 09:18:27 -05:00
Andrés Eduardo García Márquez 891d177b8c feat(frontend): implement authentication UI and guards
- Add AuthService with login/logout/register functionality
- Create auth guard for protected routes
- Create guest guard for login/register pages
- Add auth interceptor to attach JWT tokens
- Create login page with form validation
- Create register page with student profile option
- Update app component with user menu and logout
- Configure routes with authentication guards
2026-01-08 09:14:52 -05:00
Andrés Eduardo García Márquez cf61fb70e3 feat(backend): implement JWT authentication and authorization
- Add User entity with roles (Admin, Student)
- Create JWT service for token generation/validation
- Create password service using PBKDF2
- Add login and register GraphQL mutations
- Apply [Authorize] attributes to protected mutations
- DeleteStudent requires Admin role
- UpdateStudent/Enroll/Unenroll require owner or admin
- Add admin user creation on startup
2026-01-08 09:14:42 -05:00
Andrés Eduardo García Márquez bcfd2ba6f9 docs(qa): add manual QA testing report and dev startup script
- Add comprehensive QA report with 11 test cases and screenshots
- Document DEF-001 bug analysis, solutions, and resolution
- Add dev-start.sh script for faster development server startup
- Include recommendations for UX, technical, and quality improvements
2026-01-08 08:41:24 -05:00
Andrés Eduardo García Márquez 12a4c881f5 fix(frontend): resolve edit student navigation and signal timing issues
- Change edit button from <button> to <a> for proper routerLink binding
- Replace ngOnInit with effect() to handle input signal timing correctly
- The route param 'id' was not available during ngOnInit lifecycle

Fixes DEF-001: "Estudiante no encontrado" error when clicking edit
2026-01-08 08:41:14 -05:00
Andrés Eduardo García Márquez 5156689e13 fix(frontend): enforce no-explicit-any and fix test stability
- Change ESLint no-explicit-any from 'warn' to 'error'
- Replace 'any' with 'unknown as string' in initials.pipe.spec
- Fix StudentService tests to handle Apollo watchQuery multiple emissions
- Add filter for loading state before asserting in tests

Stricter type checking improves code quality.
2026-01-08 00:31:16 -05:00
Andrés Eduardo García Márquez f70cbc42d8 refactor(frontend): use centralized constants and add JSDoc
- Add comprehensive JSDoc to StudentService and EnrollmentService
- Replace magic numbers with ENROLLMENT_LIMITS constants
- Use RESTRICTION_TRANSLATIONS for enrollment messages
- Update CreditsPipe to use MAX_CREDITS constant
- Expose maxCredits and maxSubjects in enrollment component

This improves code maintainability and developer experience.
2026-01-08 00:31:05 -05:00
Andrés Eduardo García Márquez 41994ef8c5 chore(frontend): add Prettier configuration
- Configure printWidth: 100, singleQuote: true, trailingComma: es5
- Add Angular template parser override
- Ignore dist, node_modules, .angular, coverage
- Ignore generated GraphQL types
2026-01-08 00:30:51 -05:00
Andrés Eduardo García Márquez dfb1341b2c test(frontend): add comprehensive ErrorHandlerService tests
- Test all GraphQL error codes (MAX_ENROLLMENTS, SAME_PROFESSOR, etc.)
- Test network errors with different status codes
- Test validation errors with field details
- Test HTTP error handling (500, 0, 400)
- Test unknown/null/undefined error handling
- Test notification display with suggestions

Increases code coverage for the error handling layer.
2026-01-08 00:30:35 -05:00
Andrés Eduardo García Márquez 3d4a8b56ff feat(frontend): add reusable form validators
- Create emailValidator with stricter pattern than Angular's built-in
- Create nameValidator with configurable minLength, maxLength, allowNumbers
- Support for Spanish characters (accents, ñ, ü)
- Export validators from shared module
- Add JSDoc documentation with usage examples
2026-01-08 00:30:20 -05:00
Andrés Eduardo García Márquez bde0d53ba3 feat(frontend): add centralized constants for enrollment limits
- Create enrollment.constants.ts with MAX_SUBJECTS, MAX_CREDITS, CREDITS_PER_SUBJECT
- Create error-messages.constants.ts with ERROR_CODES and RESTRICTION_TRANSLATIONS
- Remove empty folders: core/state, shared/directives, features/dashboard
- Use 'as const' for type-safe constants

This improves maintainability by having a single source of truth for business rules.
2026-01-08 00:30:09 -05:00
Andrés Eduardo García Márquez b234c9c5de docs(qa): add QA testing report with defects and screenshots
Add comprehensive QA testing documentation:
- DEFECTOS-QA.md: Detailed defect report with 4 issues found
- screenshots/: 12 screenshots documenting defects and validations

Defects documented:
- DEF-001: SQL Server OOMKilled (Critical) - FIXED
- DEF-002: Messages in English (High) - FIXED
- DEF-003: Pluralization error (Medium) - FIXED
- DEF-004: Favicon 404 (Low) - FIXED

All defects include root cause analysis, proposed solutions,
and unified implementation approach.
2026-01-08 00:02:29 -05:00
Andrés Eduardo García Márquez 5af9071fde fix(frontend): add favicon and update references
- Create favicon.svg with blue "S" logo matching app branding
- Update index.html to reference favicon.svg instead of favicon.ico
- Add favicon.svg to angular.json assets configuration

Fixes DEF-004: Browser was showing 404 error for missing favicon.ico
in the console.
2026-01-08 00:02:19 -05:00
Andrés Eduardo García Márquez ac6119b265 fix(frontend): correct pluralization in classmates count
Use ternary operator to display correct singular/plural form:
- "1 compañero" (singular) when count === 1
- "X compañeros" (plural) otherwise

Fixes DEF-003: Page incorrectly showed "1 compañeros" instead of
"1 compañero" when there was exactly one classmate.
2026-01-08 00:02:09 -05:00
Andrés Eduardo García Márquez e0c130294f fix(frontend): translate enrollment restriction messages to Spanish
Add translateReason() method to convert API messages to Spanish:
- "Already enrolled" -> "Ya inscrito"
- "Already have a subject with this professor" -> "Ya tienes una materia con este profesor"
- "Maximum 3 subjects reached" -> "Máximo 3 materias alcanzado"

Apply translation to both warning text and tooltip.

Fixes DEF-002: Messages were displaying in English instead of Spanish,
breaking UI language consistency.
2026-01-08 00:02:00 -05:00
Andrés Eduardo García Márquez a899f3f19b fix(k8s): optimize API and frontend resource configuration
API deployment:
- Add .NET GC optimization flags (gcServer=0, GCConserveMemory=9)
- Increase memory requests/limits for stability
- Add GCHeapCount and gcConcurrent settings

Frontend deployment:
- Adjust resource limits for better stability
- Update probe configurations
2026-01-08 00:01:49 -05:00
Andrés Eduardo García Márquez bbeea1ae24 fix(k8s): increase SQL Server memory to prevent OOMKilled
- Increase memory limit from 1Gi to 1.5Gi
- Increase MSSQL_MEMORY_LIMIT_MB from 768 to 1024
- Increase liveness probe initialDelaySeconds to 120
- Increase failureThreshold to 5 for more tolerance
- Increase readiness probe timeouts

Fixes DEF-001: SQL Server was crashing with Exit Code 137 (OOMKilled)
due to insufficient memory allocation for SQL Server 2022 Express.
2026-01-08 00:01:39 -05:00
Andrés Eduardo García Márquez eacace330d chore: ignore Playwright MCP cache directory 2026-01-07 23:01:27 -05:00
Andrés Eduardo García Márquez aa39772261 chore(backend): add solution file and build configuration
- StudentEnrollment.sln with all project references
- Directory.Build.props for shared build settings
2026-01-07 23:01:13 -05:00
Andrés Eduardo García Márquez 4fa8dc03a0 docs: add project documentation and env template
Environment:
- .env.example template with all configuration variables
- Database, API, GraphQL, and frontend settings

Documentation:
- Architecture Decision Records (ADR-001 to ADR-004)
- Deployment guide with Docker and K8s instructions
- OWASP security checklist
- Code review checklist
- Activity plan and deliverables

Architecture diagrams (PlantUML):
- Use cases, domain model, sequence diagrams
- Component, ER, state, and deployment diagrams
- C4 context diagram
2026-01-07 23:00:56 -05:00
Andrés Eduardo García Márquez c0a47c2ba6 feat(deploy): add Docker and Kubernetes deployment
Docker:
- Multi-stage Dockerfile for API (.NET 10)
- Multi-stage Dockerfile for frontend (Angular + Nginx)
- docker-compose.yml with resource optimization
- Nginx reverse proxy configuration
- Health checks for all services

Kubernetes (k3s):
- Namespace and ConfigMap
- SQL Server StatefulSet with PVC
- API Deployment with HPA
- Frontend Deployment
- Services and Ingress
- Network policies for security
- Secrets management

Resource optimization:
- SQL Server Express with 1GB RAM limit
- API with 512MB limit
- Frontend with 128MB limit
2026-01-07 23:00:41 -05:00
Andrés Eduardo García Márquez 874b67d07f test: add unit and integration tests
Domain Tests:
- StudentTests: entity creation and validation
- EmailTests: value object validation
- EnrollmentDomainServiceTests: business rules

Application Tests:
- EnrollStudentCommandTests: enrollment scenarios
  - Max 3 subjects validation
  - Same professor constraint

Uses xUnit, Moq, and FluentAssertions
2026-01-07 23:00:27 -05:00
Andrés Eduardo García Márquez 84d88c91d1 feat(frontend): add Angular 21 SPA with Material Design
Core:
- Apollo Angular for GraphQL integration
- Student and Enrollment services
- Connectivity monitoring with health checks
- Error handling with user-friendly messages

Features:
- Students: list, create, edit, delete
- Enrollment: subject selection with validation feedback
- Classmates: view students in shared subjects

Shared Components:
- ConfirmDialog, EmptyState, LoadingSpinner
- ConnectivityOverlay for offline detection
- Custom pipes (credits, initials)

UI:
- Angular Material with custom theme
- Responsive layout with navigation
- Real-time validation feedback
2026-01-07 23:00:12 -05:00
Andrés Eduardo García Márquez 6f16ff2336 feat(host): add composition root and API configuration
- Program.cs with dependency injection setup
- Database connection retry logic with detailed logging
- Serilog structured logging configuration
- CORS configuration from environment variables
- Response compression (Brotli + Gzip)
- Rate limiting for GraphQL endpoint
- Health checks with database verification
- OWASP security headers middleware
- Output caching for read-heavy operations
2026-01-07 22:59:56 -05:00
Andrés Eduardo García Márquez 60d35f1040 feat(adapters): add driven and driving adapters
Driven Adapters (Persistence):
- AppDbContext with EF Core configurations
- Repository implementations (Student, Subject, Professor, Enrollment)
- UnitOfWork pattern for transactions
- DataLoaders for GraphQL N+1 optimization
- Database seeding with 5 professors and 10 subjects
- EF Core migrations for SQL Server

Driving Adapters (API):
- GraphQL API with HotChocolate
- Query and Mutation types
- Type definitions for all entities
- GraphQLErrorFilter for domain exceptions
2026-01-07 22:59:38 -05:00
Andrés Eduardo García Márquez 68e420fdf2 feat(application): add CQRS application layer
Commands:
- CreateStudent, UpdateStudent, DeleteStudent
- EnrollStudent, UnenrollStudent

Queries:
- GetStudents, GetStudentById, GetStudentsPaged
- GetSubjects, GetAvailableSubjects
- GetProfessors
- GetClassmates

DTOs:
- StudentDto, SubjectDto, ProfessorDto, EnrollmentDtos

Validation:
- FluentValidation with ValidationBehavior pipeline
- EnrollStudentValidator for input validation

Uses MediatR for command/query dispatching
2026-01-07 22:59:23 -05:00
Andrés Eduardo García Márquez 2d6c08e14a feat(domain): add core domain layer
Entities:
- Student: core entity with email validation
- Subject: course with credits (3 each)
- Professor: instructor managing 2 subjects
- Enrollment: student-subject relationship

Value Objects:
- Email: validated email with domain rules

Domain Services:
- EnrollmentDomainService: validates business rules
  - Max 3 subjects per student (9 credits)
  - No duplicate professor constraint

Ports:
- Repository interfaces for dependency inversion
2026-01-07 22:59:10 -05:00
Andrés Eduardo García Márquez dfcfca0b4e chore: add initial project configuration
- Add .gitignore for .NET, Node.js, and IDE files
- Add README.md with project overview
2026-01-07 22:58:56 -05:00