- Make name and email required in registration form
- Add StudentDashboard component with enrolled subjects and program info
- Implement role-based navigation (admin sees management, student sees portal)
- Add adminGuard for restricting student management routes
- Redirect to /dashboard after login/register instead of /students
- Add navigation links: Mi Portal, Mis Materias, Companeros
Fulfills test requirements:
- Students can register online (punto 1)
- Enroll in up to 3 subjects/9 credits (puntos 2-5)
- Cannot have same professor twice (punto 7)
- View classmates by subject - names only (puntos 8-9)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add centralized ValidationPatterns with XSS protection and name regex
- Add query validators (GetClassmates, GetStudentById, GetStudentsPaged, GetAvailableSubjects)
- Add ClassmateInfo read model for optimized query projections
- Add test builders (Student, Subject, Professor, Enrollment) for cleaner tests
- Improve repository interfaces with XML documentation
- Refactor EnrollmentRepository for better performance
- Update EnrollmentDomainService with additional validation helpers
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add AuthService with login/logout/register functionality
- Create auth guard for protected routes
- Create guest guard for login/register pages
- Add auth interceptor to attach JWT tokens
- Create login page with form validation
- Create register page with student profile option
- Update app component with user menu and logout
- Configure routes with authentication guards
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add User entity with roles (Admin, Student)
- Create JWT service for token generation/validation
- Create password service using PBKDF2
- Add login and register GraphQL mutations
- Apply [Authorize] attributes to protected mutations
- DeleteStudent requires Admin role
- UpdateStudent/Enroll/Unenroll require owner or admin
- Add admin user creation on startup
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add comprehensive QA report with 11 test cases and screenshots
- Document DEF-001 bug analysis, solutions, and resolution
- Add dev-start.sh script for faster development server startup
- Include recommendations for UX, technical, and quality improvements
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change edit button from <button> to <a> for proper routerLink binding
- Replace ngOnInit with effect() to handle input signal timing correctly
- The route param 'id' was not available during ngOnInit lifecycle
Fixes DEF-001: "Estudiante no encontrado" error when clicking edit
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change ESLint no-explicit-any from 'warn' to 'error'
- Replace 'any' with 'unknown as string' in initials.pipe.spec
- Fix StudentService tests to handle Apollo watchQuery multiple emissions
- Add filter for loading state before asserting in tests
Stricter type checking improves code quality.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add comprehensive JSDoc to StudentService and EnrollmentService
- Replace magic numbers with ENROLLMENT_LIMITS constants
- Use RESTRICTION_TRANSLATIONS for enrollment messages
- Update CreditsPipe to use MAX_CREDITS constant
- Expose maxCredits and maxSubjects in enrollment component
This improves code maintainability and developer experience.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Test all GraphQL error codes (MAX_ENROLLMENTS, SAME_PROFESSOR, etc.)
- Test network errors with different status codes
- Test validation errors with field details
- Test HTTP error handling (500, 0, 400)
- Test unknown/null/undefined error handling
- Test notification display with suggestions
Increases code coverage for the error handling layer.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create emailValidator with stricter pattern than Angular's built-in
- Create nameValidator with configurable minLength, maxLength, allowNumbers
- Support for Spanish characters (accents, ñ, ü)
- Export validators from shared module
- Add JSDoc documentation with usage examples
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create enrollment.constants.ts with MAX_SUBJECTS, MAX_CREDITS, CREDITS_PER_SUBJECT
- Create error-messages.constants.ts with ERROR_CODES and RESTRICTION_TRANSLATIONS
- Remove empty folders: core/state, shared/directives, features/dashboard
- Use 'as const' for type-safe constants
This improves maintainability by having a single source of truth for business rules.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create favicon.svg with blue "S" logo matching app branding
- Update index.html to reference favicon.svg instead of favicon.ico
- Add favicon.svg to angular.json assets configuration
Fixes DEF-004: Browser was showing 404 error for missing favicon.ico
in the console.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use ternary operator to display correct singular/plural form:
- "1 compañero" (singular) when count === 1
- "X compañeros" (plural) otherwise
Fixes DEF-003: Page incorrectly showed "1 compañeros" instead of
"1 compañero" when there was exactly one classmate.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add translateReason() method to convert API messages to Spanish:
- "Already enrolled" -> "Ya inscrito"
- "Already have a subject with this professor" -> "Ya tienes una materia con este profesor"
- "Maximum 3 subjects reached" -> "Máximo 3 materias alcanzado"
Apply translation to both warning text and tooltip.
Fixes DEF-002: Messages were displaying in English instead of Spanish,
breaking UI language consistency.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Increase memory limit from 1Gi to 1.5Gi
- Increase MSSQL_MEMORY_LIMIT_MB from 768 to 1024
- Increase liveness probe initialDelaySeconds to 120
- Increase failureThreshold to 5 for more tolerance
- Increase readiness probe timeouts
Fixes DEF-001: SQL Server was crashing with Exit Code 137 (OOMKilled)
due to insufficient memory allocation for SQL Server 2022 Express.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- StudentEnrollment.sln with all project references
- Directory.Build.props for shared build settings
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Environment:
- .env.example template with all configuration variables
- Database, API, GraphQL, and frontend settings
Documentation:
- Architecture Decision Records (ADR-001 to ADR-004)
- Deployment guide with Docker and K8s instructions
- OWASP security checklist
- Code review checklist
- Activity plan and deliverables
Architecture diagrams (PlantUML):
- Use cases, domain model, sequence diagrams
- Component, ER, state, and deployment diagrams
- C4 context diagram
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Docker:
- Multi-stage Dockerfile for API (.NET 10)
- Multi-stage Dockerfile for frontend (Angular + Nginx)
- docker-compose.yml with resource optimization
- Nginx reverse proxy configuration
- Health checks for all services
Kubernetes (k3s):
- Namespace and ConfigMap
- SQL Server StatefulSet with PVC
- API Deployment with HPA
- Frontend Deployment
- Services and Ingress
- Network policies for security
- Secrets management
Resource optimization:
- SQL Server Express with 1GB RAM limit
- API with 512MB limit
- Frontend with 128MB limit
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Domain Tests:
- StudentTests: entity creation and validation
- EmailTests: value object validation
- EnrollmentDomainServiceTests: business rules
Application Tests:
- EnrollStudentCommandTests: enrollment scenarios
- Max 3 subjects validation
- Same professor constraint
Uses xUnit, Moq, and FluentAssertions
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Driven Adapters (Persistence):
- AppDbContext with EF Core configurations
- Repository implementations (Student, Subject, Professor, Enrollment)
- UnitOfWork pattern for transactions
- DataLoaders for GraphQL N+1 optimization
- Database seeding with 5 professors and 10 subjects
- EF Core migrations for SQL Server
Driving Adapters (API):
- GraphQL API with HotChocolate
- Query and Mutation types
- Type definitions for all entities
- GraphQLErrorFilter for domain exceptions
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Andrés Eduardo García Márquez